Skip to content

Linked Clone : Helpers for linked-clone #3661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Linked Clone : Helpers for linked-clone #3661

wants to merge 1 commit into from
+490 −0

Conversation

bn023052
Copy link
Contributor

@bn023052 bn023052 commented Oct 7, 2025

What this PR does / why we need it:
These are the helpers needed for linked clone tests

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
This includes helpers needed for linked clone tests.

  1. linked_clone_concurrent_helper.go has methods needed for concurrent operation
  2. linked_clone_helper.go has all other methods needed by the test

Testing done:
Yes.
https://gist.github.com/bn023052/a47a7f15ff439ad5571461c5e251d537

Special notes for your reviewer:
/Users/nayakb/go/bin/golangci-lint run --enable=lll --timeout 10m

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bn023052
Once this PR has been reviewed and has the lgtm label, please assign kavyashree-r for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from sipriyaa October 7, 2025 18:31
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @bn023052. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavyashree-r kavyashree-r Awaiting requested review from kavyashree-r

@sipriyaa sipriyaa Awaiting requested review from sipriyaa

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bn023052 @k8s-ci-robot